Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable partitioned cookies by default. #22391

Merged
merged 1 commit into from Feb 29, 2024
Merged

Enable partitioned cookies by default. #22391

merged 1 commit into from Feb 29, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Feb 29, 2024

Partitioned cookies feature does not interfere with out Ephemeral Storage implementation so it's fine to enable it.

Resolves brave/brave-browser#36450

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov self-assigned this Feb 29, 2024
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Feb 29, 2024
@goodov goodov added the CI/skip-ios Do not run CI builds for iOS label Feb 29, 2024
@goodov goodov marked this pull request as ready for review February 29, 2024 08:42
@goodov goodov requested a review from a team as a code owner February 29, 2024 08:42
@goodov goodov merged commit aff6650 into master Feb 29, 2024
23 checks passed
@goodov goodov deleted the issues/36450 branch February 29, 2024 11:19
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 29, 2024
goodov added a commit that referenced this pull request Feb 29, 2024
Enable partitioned cookies by default.
brave-builds added a commit that referenced this pull request Feb 29, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.49 Chromium: 122.0.6261.94 (Official Build) nightly (64-bit)
-- | --
Revision | da6ba557e9bdb49517ffee192ba7d48ebe105ea8
OS | Windows 11 Version 23H2 (Build 22631.3235)

Using the STR/information detailed via brave/brave-browser#36450 (comment), ensured that logging into https://unomail.sharepoint.com produced an error message as I don't have a Sharepoint account rather than failing via Something went wrong as per the following:

image

Also went through https://dev-pages.brave.software/storage/ephemeral-storage.html and verified that all the tests passed as per:

Using Brave 1.64.31+ with Chromium storage partitioning, ensured all three tests/shield states passed as per:

  • Cross-site cookies blocked - PASSED
  • Cookies Blocked - PASSED
  • All cookies allowed - PASSED

kjozwiak pushed a commit that referenced this pull request Mar 3, 2024
kjozwiak pushed a commit that referenced this pull request Mar 3, 2024
Merge pull request #22391 from brave/issues/36450

Enable partitioned cookies by default.
@goodov goodov mentioned this pull request Mar 18, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/skip-ios Do not run CI builds for iOS
Projects
None yet
3 participants