Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup and migrate to Chromium blob partitioning impl. #22619

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Mar 15, 2024

Resolves brave/brave-browser#35686

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Mar 15, 2024
@goodov goodov changed the title Issues/35686 Fixup and migrate to Chromium blob partitioning impl. Mar 15, 2024
@goodov goodov force-pushed the issues/35686 branch 2 times, most recently from 7d50004 to d7d56d7 Compare March 28, 2024 06:31
@goodov goodov marked this pull request as ready for review March 28, 2024 12:28
@goodov goodov requested review from a team as code owners March 28, 2024 12:28
@goodov goodov requested a review from iefremov March 28, 2024 12:28
@goodov goodov merged commit 3d901ec into master Apr 1, 2024
19 checks passed
@goodov goodov deleted the issues/35686 branch April 1, 2024 13:36
@github-actions github-actions bot added this to the 1.66.x - Nightly milestone Apr 1, 2024
@tophf
Copy link

tophf commented May 11, 2024

According to my bisect in violentmonkey/violentmonkey#2098 this breaks fetch(blobUrl) inside an isolated world (content script) of chrome extensions where blobUrl is created by the extension's background script via URL.createObjectURL() and looks like blob:chrome-extension://bhlejohahnjoegdhipncajfeefppembn/35ec611b-0186-4b9c-acfb-787211fda68a

The error is Failed to fetch and devtools shows the request as (canceled), no further info.
Chrome doesn't have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
3 participants