-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Display Sync code expiry when showing the pairing codes #23051
Conversation
ad73b42
to
08519d6
Compare
08519d6
to
25e9c28
Compare
25e9c28
to
cd23778
Compare
android/java/org/chromium/chrome/browser/settings/BraveSyncScreensPreference.java
Outdated
Show resolved
Hide resolved
[puLL-Merge] - brave/brave-core@23051 DescriptionThis PR makes various UI changes to the Brave Sync settings screens on Android. It updates colors, layouts, and text to match a new design. It also adds a new feature to display countdown timers for sync codes and QR codes, showing how long they remain valid before expiring. ChangesChangesandroid/brave_java_resources.gni
android/brave_java_sources.gni
android/java/org/chromium/chrome/browser/BraveSyncWorker.java
android/java/org/chromium/chrome/browser/settings/BraveSyncCodeCountdownFragment.java
android/java/org/chromium/chrome/browser/settings/BraveSyncScreensPreference.java
android/java/res/*
browser/android/brave_sync_worker.cc
Security HotspotsNone found. The changes deal with UI and don't appear to introduce any new security risks. |
fixes brave/brave-browser#37725 Co-authored-by: Deep Pandya <5146988+deeppandya@users.noreply.github.com>
Co-authored-by: Deep Pandya <5146988+deeppandya@users.noreply.github.com>
ee6e83d
to
ace2096
Compare
removed |
Resolves brave/brave-browser#37725
This PR does two things:
Parent issue: brave/brave-browser#31904
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
I. QR code
Add New Device
buttonAdd a Mobile Device
Code expired
warning is shown,Generate New Code
button appearedGenerate New Code
buttonGenerate New Code
button is hidden and there is a new coundown from 30 minutes.II. Code words
Add New Device
buttonAdd a Computer
*. There is no point to wait 2 days to verify, also it is impossible to adjust the time and date after a midday because when the system time is adjusted backwards,
java.util.Timer
gets stopped.Videos:
Light theme:
Light_v5.mp4
Dark theme:
Dark_v5.mp4