Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting --ozone-platform-hint fix #23166

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Apr 19, 2024

This change is landing in down the line in chromium upstream, but for the moment current users of 1.66.x and 1.65.x are being affected.

https://chromium-review.googlesource.com/c/chromium/src/+/5375669

Chromium change:
https://chromium.googlesource.com/chromium/src/+/c7f4c58f896a651eba80ad805ebdb49d19ebdbd4

commit c7f4c58f896a651eba80ad805ebdb49d19ebdbd4
Author: Tom Anderson thomasanderson@chromium.org
Date: Wed Mar 20 00:00:12 2024 +0000

Fix --ozone-platform-hint

This fixes a regression after r1269993 which moved ozone platform
early initialization before the ozone platform hint flag was
processed.  This CL ensures the flag processing happens even earlier.

R=sky

Change-Id: Icc9649beb0b86753265be2b6cdf3059611eb410f
Bug: None

Resolves brave/brave-browser#37498

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This change is landing in down the line in chromium upstream, but for
the moment current users of 1.66.x and 1.65.x are being affected.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/c7f4c58f896a651eba80ad805ebdb49d19ebdbd4

commit c7f4c58f896a651eba80ad805ebdb49d19ebdbd4
Author: Tom Anderson <thomasanderson@chromium.org>
Date:   Wed Mar 20 00:00:12 2024 +0000

    Fix --ozone-platform-hint

    This fixes a regression after r1269993 which moved ozone platform
    early initialization before the ozone platform hint flag was
    processed.  This CL ensures the flag processing happens even earlier.

    R=sky

    Change-Id: Icc9649beb0b86753265be2b6cdf3059611eb410f
    Bug: None
@cdesouza-chromium cdesouza-chromium self-assigned this Apr 19, 2024
@cdesouza-chromium cdesouza-chromium requested a review from a team as a code owner April 19, 2024 12:34
Copy link
Contributor

The following commits were not verified:
575b3b0 (unsigned)

@kjozwiak
Copy link
Member

Verification PASSED on Fedora 39 x64 using the following build(s):

Brave | 1.67.26 Chromium: 124.0.6367.60 (Official Build) nightly (64-bit)
--- | ---
Revision | fb129438acc3c97a8676d7e77cf0b40925e46aad
OS | Linux

Reproduced the original issue by setting ozone-platform-hint to Wayland via brave://flags as per the following:

Example Example
Screenshot_20240420_014644 Screenshot_20240420_014712

Once reproduced, downloaded/installed 1.67.26 Chromium: 124.0.6367.60 and ensured that Brave was being opened and rendering websites without any issues while ozone-platform-hint was set as Wayland. Also ensured that the default installation worked without any issues.

Screenshot_20240420_015001

kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
sangwoo108 pushed a commit that referenced this pull request Apr 22, 2024
mkarolin added a commit that referenced this pull request Apr 23, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
mkarolin added a commit that referenced this pull request Apr 24, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
mkarolin added a commit that referenced this pull request Apr 26, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
cdesouza-chromium pushed a commit that referenced this pull request Apr 29, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
cdesouza-chromium pushed a commit that referenced this pull request Apr 29, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
mkarolin added a commit that referenced this pull request Apr 29, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
mkarolin added a commit that referenced this pull request Apr 29, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
cdesouza-chromium pushed a commit that referenced this pull request Apr 30, 2024
This code is already in Chromium 125.

This reverts commit 40d6c38.
mkarolin added a commit that referenced this pull request Apr 30, 2024
This reverts commit 40d6c38.

The current cr 124 bump (124.0.6367.118) includes this fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants