-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Microsoft Bing to Bing #23526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. Did not test it to see if it fixes the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#38179 (comment), ensured that the correct SE were being selected. Also ensured that screen-20240513-141329.mp4 |
Uplift of #23526 (squashed) to beta
Uplift of #23526 (squashed) to release
fix brave/brave-browser#38179
AFAIK, android caches search provider's name in prefs.
So, if existing provider's name is changed, it could affect default search provider.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue.