-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom text filter list #23548
Add custom text filter list #23548
Conversation
b0477f9
to
a3a539d
Compare
9309c4a
to
5c44aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. One nit: we have Custom filter lists
menu on top and custom filters
on the bottom. Can we group it in one place? It's confusing right now
5c44aca
to
b99b444
Compare
b99b444
to
ce75fd2
Compare
ios/brave-ios/Sources/Brave/WebFilters/ContentBlocker/ContentBlockerManager.swift
Show resolved
Hide resolved
e970436
to
3db6aa4
Compare
3db6aa4
to
420082c
Compare
[puLL-Merge] - brave/brave-core@23548 DescriptionThis PR makes a few changes to the filter list and custom filter functionality in the iOS app:
The motivation seems to be to allow users to easily add their own custom adblock rules within the app itself, in addition to the existing functionality of adding custom filter list URLs. ChangesChanges
Overall, this is a significant feature addition that is implemented across several files. The code looks well-organized and includes proper error handling and validation. |
Resolves brave/brave-browser#36034
Security review: https://github.com/brave/reviews/issues/1612
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Valid rules
Invalid rules
Placeholder
Video
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-05-29.at.13.01.18.mp4
Screenshots