Adds different text to grant finish screen #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
requested changes
Jun 12, 2019
| "description": "Cosmetic text upon captcha success for ads" | ||
| }, | ||
| "grantFinishTextAds": { | ||
| "message": "Your rewards grant from Brave Ads is on its way", |
There was a problem hiding this comment.
needs a full-stop to be consistent with UGP
| grant.expiryTime = 0 | ||
| grant.finishText = getMessage('grantFinishTextAds') |
There was a problem hiding this comment.
nit: for consistency swap text/title lines around so they match above
| @@ -135,14 +135,43 @@ class Grant extends React.Component<Props, State> { | |||
| ) | |||
| } | |||
|
|
|||
| grantFinish = (type: string, tokens: string, date: string) => { | |||
| let title = getLocale('grantFinishTitleUGP') | |||
There was a problem hiding this comment.
nit: could we not move to these to an else statement
| return grant | ||
| } | ||
|
|
||
| grant.finishTitle = getMessage('grantFinishTitleUGP') |
There was a problem hiding this comment.
nit: could we not move to these to an else statement
| @@ -524,6 +522,13 @@ | |||
| <message name="IDS_BRAVE_UI_SHOW_ALL" desc="">Show All</message> | |||
| <message name="IDS_BRAVE_UI_SUPPORTED_SITES" desc="">Supported Sites</message> | |||
|
|
|||
| <message name="IDS_BRAVE_UI_GRANT_FINISH_TOKEN_ADS" desc="Token text on final grant screen for UGP">Your Brave Ads Token Grant</message> | |||
| <message name="IDS_BRAVE_UI_GRANT_FINISH_TEXT_ADS" desc="Text on final grant screen for UGP">Your rewards grant from Brave Ads is on its way</message> | |||
There was a problem hiding this comment.
needs a full-stop to be consistent with UGP
NejcZdovc
force-pushed
the
grant-text
branch
2 times, most recently
from
e046a5a
to
b55c349
Compare
tmancey
previously approved these changes
Jun 12, 2019
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
put ads header in BRAVE_ADS_ENABLED guard
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
put ads header in BRAVE_ADS_ENABLED guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#4814
UI PR: brave/brave-ui#499
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Test plan 1:
Test plan 1:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.