Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Rewards Grant Panel changes! #4814

Closed
mandar-brave opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2670
Closed

Ads Rewards Grant Panel changes! #4814

mandar-brave opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2670

Comments

@mandar-brave
Copy link

mandar-brave commented Jun 11, 2019

Horizontal claim (Change text): Your rewards from Ads are here!

image

Vertical claim (Change text):
Replace 'It's your lucky day!' to 'Brave Ads Rewards!'
Replace 'Your token grant is on its way' to " Your rewards grant from Brave Ads is on its way"
Replace: 'Free Token Grant' to " Your Brave Ads Token Grant'

image

Cross-reference: #4330
@tmancey @alexwykoff

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 11, 2019
@mandar-brave mandar-brave added this to New Issues in Rewards via automation Jun 11, 2019
@alexwykoff alexwykoff self-assigned this Jun 11, 2019
@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 11, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
@tmancey tmancey assigned NejcZdovc and unassigned alexwykoff Jun 12, 2019
@jsecretan jsecretan moved this from New Issues to Backlog in Rewards Jun 12, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
Rewards automation moved this from Backlog to Done Jun 12, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2019

Verification passed on

Brave 0.68.104 Chromium: 75.0.3770.100 (Official Build) dev (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description
    • Verified that the Horizontal claim text changed to "Your rewards from Ads are here!"
      image

    • Verified that the Vertical claim text 'It's your lucky day!' changed to 'Brave Ads Rewards!'

    • Verified that 'Your token grant is on its way' changed to " Your rewards grant from Brave Ads is on its way"

    • Verified that 'Free Token Grant' changed to " Your Brave Ads Token Grant'

image

  • Verified the STR from the description
    • Verified that the Horizontal claim text changed to "Your rewards from Ads are here!"
    • Verified that the Vertical claim text 'It's your lucky day!' changed to 'Brave Ads Rewards!'
    • Verified that 'Your token grant is on its way' changed to " Your rewards grant from Brave Ads is on its way"
    • Verified that 'Free Token Grant' changed to " Your Brave Ads Token Grant'
      image
      image
      image

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
  • Verified test plan from Adds different text to grant finish screen brave-core#2670
  • Ad grant banner text is as expected:
    Screen Shot 2019-08-06 at 11 49 12 AM
  • Text on final screen after claiming from banner/ brave://rewards page is as expected:
    Screen Shot 2019-08-06 at 11 49 25 AM
  • Text on final screen after claiming from panel is as expected:
    Screen Shot 2019-08-06 at 11 54 01 AM
  • Text on final screen after claiming UGP grant from panel is as expected:
    Screen Shot 2019-08-06 at 11 52 34 AM
  • Text on final screen after claiming UGP grant from banner/ brave://rewards page is as expected:
    Screen Shot 2019-08-06 at 12 00 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants