Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dapp detection #2678

Merged
merged 18 commits into from
Jul 18, 2019
Merged

Add dapp detection #2678

merged 18 commits into from
Jul 18, 2019

Commits on Jul 17, 2019

  1. Add dapp detection 

    contents script in brave extension detects whether window.web3 is accessed or not
from current tab and sends a message to background script to notify to browser.
When browser gets "braveShields.dappAvailable", it shows wallet extension install
guide when dapp detection pref is enabled.
    @simonhong @bbondy
    simonhong authored and bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    f052d0a View commit details
    Browse the repository at this point in the history

  2. Fix lint errors

    @simonhong @bbondy
    simonhong authored and bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a535116 View commit details
    Browse the repository at this point in the history

  3. Load brave://wallet to install extension from Dapp detection 

    Simply loading brave://wallet will install the extension if it's not already installed
    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    d78054e View commit details
    Browse the repository at this point in the history

  4. Adjust enum patching strategy to avoid future patches

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    114d103 View commit details
    Browse the repository at this point in the history

  5. Add BRAVE_WALLET_ENABLED for Dapp detection

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    159a941 View commit details
    Browse the repository at this point in the history

  6. Dapp detection injection only for BRAVE_WALLET_ENABLED

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    829fbf1 View commit details
    Browse the repository at this point in the history

  7. Remove redundant Dapp detection pref

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    daa01c5 View commit details
    Browse the repository at this point in the history

  8. Use sender.tab.id and no need for active check 

    Since the permission prompt is properly scoped within the tab, we don't need to check active. And we don't want to check it.

The check for the frameId is just to future proof to make sure a DOS attack is not possible subframes
    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    7155744 View commit details
    Browse the repository at this point in the history

  9. Add chrome.braveWallets API

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    348bb5b View commit details
    Browse the repository at this point in the history

  10. Remove unused dappAvailable callback

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    1221260 View commit details
    Browse the repository at this point in the history

  11. Add pref to signal wallet loaded at least once 

    Thi is so that it can continue to be loaded in the future
    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    924d3e6 View commit details
    Browse the repository at this point in the history

  12. Change API dappAvailable -> promptToEnableWallet 

    It is more clear for what is being done
    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    2ac1bb4 View commit details
    Browse the repository at this point in the history

  13. Add API to see if braveWallet is enabled 

    This is different than chrome.braveWallet being available in the first place
    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a42d82b View commit details
    Browse the repository at this point in the history

  14. Execute dapp detection script only when Brave wallet not in use

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    eb31680 View commit details
    Browse the repository at this point in the history

  15. Add test for braveWallet API only available in Brave Shields extension

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a61bbbf View commit details
    Browse the repository at this point in the history

  16. Use ExtensionPrefs instead of custom pref handling

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5e1fa33 View commit details
    Browse the repository at this point in the history

  17. _api_features.json to exclude braveWallet when not avail

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    8964078 View commit details
    Browse the repository at this point in the history

  18. Move browser/dapp to browser/brave_wallet

    @bbondy
    bbondy committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    4e5c1e0 View commit details
    Browse the repository at this point in the history