Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to there is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119 #3093

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Follow up to there is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119 #3093

merged 3 commits into from
Aug 5, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 4, 2019 •
edited

Fixes brave/brave-browser#5531
Requires #3059

Submitter Checklist:

Test Plan:

Confirm upgrade paths work as expected from 0.62.51 to 0.70.37 (or above)
Confirm upgrade paths work as expected from 0.63.x to 0.70.37 (or above)
Confirm upgrade paths work as expected from 0.70.33 to 0.70.37 (or above)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey added this to the 0.70.x - Nightly milestone Aug 4, 2019
@tmancey tmancey self-assigned this Aug 4, 2019
@tmancey tmancey force-pushed the issues/5531 branch 3 times, most recently from c3eac9b to c430c07 Compare August 4, 2019 18:39
emerick
emerick previously approved these changes Aug 4, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/5531 branch 2 times, most recently from 8d6ae1a to 7ec6ed2 Compare August 5, 2019 09:40
@tmancey tmancey requested a review from emerick August 5, 2019 11:19
emerick
emerick reviewed Aug 5, 2019
View reviewed changes
components/brave_ads/browser/ads_service_impl.h Outdated
@@ -95,8 +95,11 @@ class AdsServiceImpl : public AdsService,
void Start();
bool StartService();
void UpdateIsProductionFlag();
bool IsProduction();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like these could all be const.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@emerick emerick self-requested a review August 5, 2019 14:34
emerick
emerick previously approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from emerick August 5, 2019 14:40
emerick
emerick approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit d1ce246 into master Aug 5, 2019
@tmancey tmancey deleted the issues/5531 branch August 5, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
0.69.x - Release
2 participants
@tmancey @emerick