Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to there is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119 #5531

Closed
tmancey opened this issue Aug 4, 2019 · 2 comments · Fixed by brave/brave-core#3093
Closed

Follow up to there is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119 #5531

tmancey opened this issue Aug 4, 2019 · 2 comments · Fixed by brave/brave-core#3093
Assignees
@tmancey
Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
Rewards Team
Milestone
0.69.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 4, 2019

Description

There is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119

Steps to Reproduce

Pre-requisites: VPN is connected to US region and language is set to English(US)

  1. clean profile 0.62.51
  2. enable rewards
  3. upgrade to 0.67.119

Actual result:

There is no ads enable alert, ads are enabled by default when upgrading build from 0.62.51 to 0.67.119

Expected result:

Ads enable alert should be shown on BAT logo and ads should not be enabled by default

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.67.119 Chromium: 76.0.3809.72 (Official Build) (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @tmancey
Also see #5434
@tmancey tmancey added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes regression feature/ads labels Aug 4, 2019
@tmancey tmancey added this to the 0.70.x - Nightly milestone Aug 4, 2019
@tmancey tmancey self-assigned this Aug 4, 2019
@tmancey tmancey added this to New Issues in Rewards via automation Aug 4, 2019
tmancey added a commit to brave/brave-core that referenced this issue Aug 4, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
2ae55ce 
… when upgrading build from 0.62.51 to 0.67.119

Fixes brave/brave-browser#5531
This was referenced Aug 4, 2019
Closed
Merged
tmancey added a commit to brave/brave-core that referenced this issue Aug 4, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
5f9056d 
… when upgrading build from 0.62.51 to 0.67.119

Fixes brave/brave-browser#5531
tmancey added a commit to brave/brave-core that referenced this issue Aug 4, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
c3eac9b 
… when upgrading build from 0.62.51 to 0.67.119

Fixes brave/brave-browser#5531
tmancey added a commit to brave/brave-core that referenced this issue Aug 4, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
c430c07 
… when upgrading build from 0.62.51 to 0.67.119

Fixes brave/brave-browser#5531
tmancey added a commit to brave/brave-core that referenced this issue Aug 5, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
8d6ae1a 
… when upgrading build from 0.62.51 to 0.67.119

Fixes brave/brave-browser#5531
Rewards automation moved this from New Issues to Done Aug 5, 2019
@tmancey tmancey added this to Closed in Rewards Team via automation Aug 5, 2019
tmancey added a commit to brave/brave-core that referenced this issue Aug 5, 2019
@tmancey
Follow up to there is no ads enable alert, ads are enabled by default…
d1ce246 
… when upgrading build from 0.62.51

Fixes brave/brave-browser#5531
Requires #3059
This was referenced Sep 23, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

Blocked due to #6148

@LaurenWags
Copy link
Member

LaurenWags commented Oct 2, 2019 •
edited by btlechowski

Verified passed with

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
No open projects
Rewards Team
Closed
Milestone
0.69.x - Release
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya