Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Tweak spacing on topsites removal notification #4668

Merged
merged 2 commits into from Mar 2, 2020
Merged

Conversation

cezaraugusto
Copy link
Contributor

Close brave/brave-browser#8282

Screen Shot 2020-02-17 at 2 30 03 PM

Resolves

Submitter Checklist:

Test Plan:

See screenshot attached.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but thanks for the fix otherwise and apologies for breaking this! CI looks a bit weird, so I kicked it off again, though this is such a minimal css change 🤷‍♂

@bsclifton bsclifton added this to the 1.7.x - Nightly milestone Mar 2, 2020
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 2, 2020
@bsclifton
Copy link
Member

CI looks good (Linux browser test had intermittent failure for autoplay test) except for iOS. Going to re-run only iOS

…dex.ts


Accepting per review feedback

Co-Authored-By: Pete Miller <miller.pete@gmail.com>
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2020

Verification PASSED on macOS 10.15.3 x64` using the following build:

Brave 1.7.32 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-03-02 at 2 26 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/newtab
Projects
None yet
4 participants