Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify cargo dependency version and not force reinstall #5525

Merged
merged 1 commit into from
May 12, 2020

Conversation

AndriusA
Copy link

@AndriusA AndriusA commented May 12, 2020

Resolves brave/brave-browser#9744

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AndriusA
Copy link
Author

Ci is green but for test-install step on macos, doesn't seem related

@AndriusA AndriusA merged commit 8c40265 into master May 12, 2020
@AndriusA AndriusA deleted the cbindgen-version branch May 12, 2020 15:21
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 12, 2020
@bsclifton
Copy link
Member

@AndriusA can we please make sure to set the milestone for PRs and issues before merging? Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid unnecessarily reinstalling cbindgen
3 participants