Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error on SI for japan region #5908

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves : brave/brave-browser#10296

Submitter Checklist:

Test Plan:

Please follow the thread https://bravesoftware.slack.com/archives/C0816QH3R/p1592299106280900

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 18, 2020
@deeppandya deeppandya added this to the 1.12.x - Nightly milestone Jun 18, 2020
@deeppandya deeppandya self-assigned this Jun 18, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 2e644df into master Jun 18, 2020
@deeppandya deeppandya deleted the fix_for_japan_SI_dp branch June 18, 2020 22:06
brave-builds pushed a commit that referenced this pull request Jun 18, 2020
brave-builds pushed a commit that referenced this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] App crashes on opening new tab after disabling Custom Homepage theme
2 participants