Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: Register as Brave instead of Chromium #6209

Merged
merged 1 commit into from Jul 28, 2020

Conversation

keur
Copy link
Contributor

@keur keur commented Jul 24, 2020

When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919

Submitter Checklist:

Test Plan:

Play a song on linux and use the pavucontrol application to see that it is playing from Brave instead of Chromium.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@keur keur requested a review from bridiver as a code owner July 24, 2020 19:02
@keur
Copy link
Contributor Author

keur commented Jul 24, 2020

For all the non-linux people, I've included before & after screenshots.

Without this patch

2020-07-24_11:54:41

With the patch

2020-07-24_11:55:33

@keur
Copy link
Contributor Author

keur commented Jul 24, 2020

Pinging both @fmarier and @antonok-edm to take a look since you both use Linux.

@keur keur added this to the 1.13.x - Nightly milestone Jul 24, 2020
@keur keur self-assigned this Jul 24, 2020
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this works correctly for me

@keur keur force-pushed the pulseaudio_application_brave branch 2 times, most recently from ee22579 to 0c0698f Compare July 27, 2020 18:05
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919
@keur keur force-pushed the pulseaudio_application_brave branch from 0c0698f to a1c5996 Compare July 27, 2020 19:34
@keur keur requested a review from bridiver July 27, 2020 19:35
@keur
Copy link
Contributor Author

keur commented Jul 28, 2020

CI passes except for audit deps. This PR doesn't add any new npm deps, so assuming that doesn't apply to these changes.

@keur keur merged commit 04150f9 into master Jul 28, 2020
@keur keur deleted the pulseaudio_application_brave branch July 28, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants