Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Register with Pulseaudio as Brave instead of Chromium #10919

Closed
keur opened this issue Jul 24, 2020 · 2 comments · Fixed by brave/brave-core#6209
Closed

[Desktop] Register with Pulseaudio as Brave instead of Chromium #10919

keur opened this issue Jul 24, 2020 · 2 comments · Fixed by brave/brave-core#6209
Assignees
@keur
Labels
OS/Desktop OS/Linux OS/unix-like/linux QA Pass-Linux QA/Yes release-notes/include
Milestone
1.14.x - Release #1

Comments

@keur
Copy link
Contributor

keur commented Jul 24, 2020

Description

Add Brave branding to pulseaudio.

Steps to Reproduce

  1. Open a pulse audio frontend like pavucontrol
  2. Play a song in Brave
  3. See that it is registered with the pulse audio server as Chromium

Actual result:

Current Display

Expected result:

Shows up as Brave.

Reproduces how often:

Always

Version/Channel Information:

  • Can you reproduce this issue with the current release? Y
  • Can you reproduce this issue with the beta channel? Y
  • Can you reproduce this issue with the nightly channel? Y
@keur keur self-assigned this Jul 24, 2020
@keur keur changed the title [Desktop] [Desktop] Register with Pulseaudio as Brave instead of Chromium Jul 24, 2020
keur added a commit to brave/brave-core that referenced this issue Jul 24, 2020
@keur
pulseaudio: Register as Brave instead of Chromium
f8960d8 
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919
@keur keur added this to the 1.13.x - Nightly milestone Jul 24, 2020
@keur keur mentioned this issue Jul 24, 2020
Merged
32 tasks
@fmarier fmarier mentioned this issue Jul 24, 2020
Closed
keur added a commit to brave/brave-core that referenced this issue Jul 27, 2020
@keur
pulseaudio: Register as Brave instead of Chromium
ee22579 
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919
keur added a commit to brave/brave-core that referenced this issue Jul 27, 2020
@keur
pulseaudio: Register as Brave instead of Chromium
0c0698f 
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919
keur added a commit to brave/brave-core that referenced this issue Jul 27, 2020
@keur
pulseaudio: Register as Brave instead of Chromium
a1c5996 
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.

Resolves brave/brave-browser#10919
@btlechowski
Copy link

Did not work on 1.13.x, but worked on 1.14.x so I moved the milestone

Verification passed on

Brave 1.14.42 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
Revision 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6209 (comment)
pavucontrol
image

System audio settings
image

@btlechowski
Copy link

Verification passed on

Brave 1.14.68 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6209 (comment)

image

@kjozwiak kjozwiak mentioned this issue Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keur keur

Labels
OS/Desktop OS/Linux OS/unix-like/linux QA Pass-Linux QA/Yes release-notes/include
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging a pull request may close this issue.

pulseaudio: Register as Brave instead of Chromium brave/brave-core
3 participants
@fmarier @keur @btlechowski