Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes bind_util #6548

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Removes bind_util #6548

merged 1 commit into from
Sep 1, 2020

Conversation

NejcZdovc
Copy link
Contributor

Resolves brave/brave-browser#11471

Submitter Checklist:

Test Plan:

  • make sure that you can claim promotion
  • make sure that you can do contribution (one time tip, recurring tip and ac)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.15.x - Nightly milestone Aug 31, 2020
@NejcZdovc NejcZdovc requested a review from a team August 31, 2020 10:22
@NejcZdovc NejcZdovc self-assigned this Aug 31, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team August 31, 2020 10:22
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to get those string passing roundtrips cleaned up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants