Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Remove bind_util #11471

Closed
NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6548
Closed

[Desktop] Remove bind_util #11471

NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#6548

Comments

@NejcZdovc
Copy link
Contributor

Bind util was created as we didn't know how to handle mojo pointers. Now we have a way with shared pointers. You can see example here https://github.com/brave/brave-core/blob/d3487abc76a2760ac1614e03b6f66dd78f4d62ca/vendor/bat-native-ledger/src/bat/ledger/internal/promotion/promotion.cc#L179

@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Aug 27, 2020
@NejcZdovc NejcZdovc self-assigned this Aug 31, 2020
@NejcZdovc NejcZdovc moved this from Backlog to In progress in Brave Rewards Aug 31, 2020
@NejcZdovc NejcZdovc moved this from In progress to Review in Brave Rewards Aug 31, 2020
@NejcZdovc NejcZdovc added this to the 1.15.x - Nightly milestone Aug 31, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 31, 2020
@NejcZdovc NejcZdovc added QA/Yes and removed QA/No labels Aug 31, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 31, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 31, 2020
Brave Rewards automation moved this from Review to Done Sep 1, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Sep 22, 2020

Verified passed with

Brave	1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6548

Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards page ss1 ss2
Confirmed brave://rewards-internals showed promotion data as expected for above UGP grant ss8
Confirmed able to do 1 time tips, recurring tips, and AC using promotion ss3 ss4 ss5 ss6 ss7
Confirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expected ss9
Confirmed able to restore a wallet with waiting ad grant and then confirmed I could claim that ad grant ss10 ss11 ss12

Verification passed on


Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards page

image
image

Confirmed brave://rewards-internals showed promotion data as expected for above UGP grant

image

Confirmed able to do 1 time tips, recurring tips, and AC using promotion

image
image
image
image
image

Confirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expected

image
image

Confirmed able to restore a wallet with waiting ad grant and then confirmed I could claim that ad grant

image
image
image


Verification passed on

Brave 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS
Confirmed able to claim promotion (UGP grant on staging) via panel, NTP widget, and brave://rewards page

image
image

Confirmed brave://rewards-internals showed promotion data as expected for above UGP grant

image

Confirmed able to do 1 time tips, recurring tips, and AC using promotion ![image](https://user-images.githubusercontent.com/34715963/93967755-3ec8e200-fd68-11ea-9e99-0783dc49a8a6.png) ![image](https://user-images.githubusercontent.com/34715963/93967816-5902c000-fd68-11ea-87a5-3ba2a3aa4dca.png) ![image](https://user-images.githubusercontent.com/34715963/93967851-7041ad80-fd68-11ea-9c40-4aea354f3eaa.png) ![image](https://user-images.githubusercontent.com/34715963/93967879-7f286000-fd68-11ea-94c1-db5b9e882841.png)
Confirmed brave://rewards-internals showed data from above contributions (1 time tips, recurring tips, AC) as expected

image
image

Confirmed able to restore a wallet with waiting ad grant and then confirmed I could claim that ad grant

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment