Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create cookie page action icon/view. #6642

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Sep 14, 2020

Fixes brave/brave-browser#11709

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.16.x - Nightly milestone Sep 14, 2020
@mkarolin mkarolin self-assigned this Sep 14, 2020
#define kCookieControls \
kCookieControls: \
break; \
case kUndefinedPageActionIconType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@mkarolin mkarolin merged commit 65100cf into master Sep 17, 2020
@mkarolin mkarolin deleted the maxk-hide-cookies-page-action-2 branch September 17, 2020 23:45
mkarolin added a commit that referenced this pull request Sep 21, 2020
Do not create cookie page action icon/view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants