Hide qr code

[NejcZdovc]

Resolves brave/brave-browser#12475

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint, npm run gn_check)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Requested a security/privacy review as needed.
• Added appropriate QA labels (QA/Yes or QA/No) to the associated issue
• Added appropriate release note labels (release-notes/include or release-notes/exclude) to the associated issue
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

• go to rewards page
• make sure that you don't see qr code box

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[emerick]

LGTM

[bsclifton]

Linux has a few browser-test failures:

16:45:40  5 tests failed:
16:45:40      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
16:45:40      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
16:45:40      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
16:45:40      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
16:45:40      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
16:45:40  1 test timed out:
16:45:40      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

Other platforms still running... if macOS/Windows look OK, I'll restart Linux to make sure

[bsclifton]

macOS failed similar browser tests too:

17:22:40  7 tests failed:
17:22:40      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
17:22:40      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
17:22:40      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
17:22:40      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
17:22:40      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
17:22:40      RewardsContributionBrowserTest.PanelMonthlyTipActions (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:954)
17:22:40      RewardsContributionBrowserTest.PanelMonthlyTipAmount (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:927)
17:22:40  1 test timed out:
17:22:40      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

Same on Windows:

18:27:39  5 tests failed:
18:27:39      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
18:27:39      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
18:27:39      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
18:27:39      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
18:27:39      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
18:27:39  1 test timed out:
18:27:39      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

[bsclifton]

I think the failures are due to #6632 - will be reverting and then we can rebase

[bsclifton]

Test failures not related to this PR; travis-ci passed, so we should be good 👍