Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide qr code #7020

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Hide qr code #7020

merged 1 commit into from
Nov 3, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 2, 2020

Resolves brave/brave-browser#12475

Submitter Checklist:

Test Plan:

  • go to rewards page
  • make sure that you don't see qr code box

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Nov 2, 2020
@NejcZdovc NejcZdovc requested a review from a team as a code owner November 2, 2020 22:41
@NejcZdovc NejcZdovc self-assigned this Nov 2, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Nov 2, 2020
@bsclifton
Copy link
Member

Linux has a few browser-test failures:

16:45:40  5 tests failed:
16:45:40      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
16:45:40      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
16:45:40      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
16:45:40      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
16:45:40      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
16:45:40  1 test timed out:
16:45:40      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

Other platforms still running... if macOS/Windows look OK, I'll restart Linux to make sure

@bsclifton
Copy link
Member

macOS failed similar browser tests too:

17:22:40  7 tests failed:
17:22:40      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
17:22:40      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
17:22:40      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
17:22:40      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
17:22:40      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
17:22:40      RewardsContributionBrowserTest.PanelMonthlyTipActions (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:954)
17:22:40      RewardsContributionBrowserTest.PanelMonthlyTipAmount (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:927)
17:22:40  1 test timed out:
17:22:40      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

Same on Windows:

18:27:39  5 tests failed:
18:27:39      AdBlockServiceTest.NewTabContinuesToBlock (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:490)
18:27:39      AdBlockServiceTest.SubFrame (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:525)
18:27:39      AdBlockServiceTest.TwoDiffAdsGetCountedAsTwo (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:466)
18:27:39      AdBlockServiceTest.TwoSameAdsGetCountedAsOne (../../brave/browser/brave_shields/ad_block_service_browsertest.cc:442)
18:27:39      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:91)
18:27:39  1 test timed out:
18:27:39      PerfPredictorTabHelperTest.NewNavigationStoresSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:112)

@bsclifton
Copy link
Member

I think the failures are due to #6632 - will be reverting and then we can rebase

@bsclifton
Copy link
Member

Test failures not related to this PR; travis-ci passed, so we should be good 👍

@bsclifton bsclifton merged commit 6456585 into master Nov 3, 2020
@bsclifton bsclifton deleted the hide-qr branch November 3, 2020 04:55
bsclifton added a commit that referenced this pull request Nov 3, 2020
bsclifton added a commit that referenced this pull request Nov 3, 2020
@NejcZdovc NejcZdovc mentioned this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
4 participants