-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide qr code #7020
Hide qr code #7020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linux has a few browser-test failures:
Other platforms still running... if macOS/Windows look OK, I'll restart Linux to make sure |
macOS failed similar browser tests too:
|
I think the failures are due to #6632 - will be reverting and then we can rebase |
Resolves brave/brave-browser#12475
Test failures not related to this PR; travis-ci passed, so we should be good 👍 |
Resolves brave/brave-browser#12475
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.