New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduces a new permission for Android 11 to allow open links in ext… #7080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
test plan required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
{% if target_sdk_version|int > 27 or target_sdk_version == "Q" %} | ||
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> | ||
{% endif %} | ||
+ {% if target_sdk_version|int > 29 or target_sdk_version == "R" %} <uses-permission android:name="android.permission.QUERY_ALL_PACKAGES"/> {% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeyZhukovsky - Looks like this issue was fixed yesterday in Chromium: https://chromium.googlesource.com/chromium/src/+/aabc32f9845740c239624bdfc4eaedf43e184b60 - I think it might make sense to pull this commit as is to reduce the rebase workload during CR bump. cc: @mkarolin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkarolin will it help on rebasing? As we have it patched already and strings are not the same as in the upstream commit in any case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I put it at the same position how it's in the upstream
ac46cda
to
8d9b296
Compare
Verification passed on Pixel 3XL with Android 11 running 1.18.41 x64 nightly build
Verification PASSED on
|
Added a link to a solution for those who cannot open external apps on Android with the default settings on Brave brave/brave-browser#12330 |
Resolves brave/brave-browser#12330
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Settings->Site settings->Video playback in Brave
and disable itcool yt video
Reviewer Checklist:
After-merge Checklist:
changes has landed on.