Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces a new permission for Android 11 to allow open links in ext… #7080

Merged
merged 1 commit into from Nov 7, 2020

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Nov 6, 2020

Resolves brave/brave-browser#12330

Submitter Checklist:

Test Plan:

  1. Install Brave on Android 11 device
  2. Go to Settings->Site settings->Video playback in Brave and disable it
  3. Type in the URL something like cool yt video
  4. Tap on some YT URL and observe that YT app is opened to play it.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 6, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.18.x - Nightly milestone Nov 6, 2020
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner November 6, 2020 21:23
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 6, 2020
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
test plan required

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

{% if target_sdk_version|int > 27 or target_sdk_version == "Q" %}
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
{% endif %}
+ {% if target_sdk_version|int > 29 or target_sdk_version == "R" %} <uses-permission android:name="android.permission.QUERY_ALL_PACKAGES"/> {% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyZhukovsky - Looks like this issue was fixed yesterday in Chromium: https://chromium.googlesource.com/chromium/src/+/aabc32f9845740c239624bdfc4eaedf43e184b60 - I think it might make sense to pull this commit as is to reduce the rebase workload during CR bump. cc: @mkarolin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkarolin will it help on rebasing? As we have it patched already and strings are not the same as in the upstream commit in any case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I put it at the same position how it's in the upstream

@srirambv
Copy link
Contributor

srirambv commented Nov 9, 2020

Verification passed on Pixel 3XL with Android 11 running 1.18.41 x64 nightly build

Verification PASSED on Pixel XL 2 on Android 11 running 1.18.43 CR: 87.0.4280.49

@pateljoel
Copy link

pateljoel commented Aug 26, 2023

Added a link to a solution for those who cannot open external apps on Android with the default settings on Brave brave/brave-browser#12330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
7 participants