Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patches from Chromium 87.0.4280.63 to Chromium 87.0.4280.66. #7167

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 17, 2020

Fixes brave/brave-browser#12741
Related PR: brave/brave-browser#12742

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin
Copy link
Collaborator Author

mkarolin commented Nov 17, 2020

1 browser test failure on MacOS CI:

1 test failed:
     RewardsPromotionBrowserTest.ClaimViaSettingsPage (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:195)

2 on Windows CI:

1 test failed:
     RewardsContributionBrowserTest.TipConnectedPublisherVerified (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:585)
 1 test timed out:
     RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:303)

Edit: verified locally and all browser tests passed.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit d794f3f into master Nov 18, 2020
@bsclifton bsclifton deleted the 87.0.4280.66 branch November 18, 2020 07:20
mkarolin pushed a commit that referenced this pull request Nov 18, 2020
Updated patches from Chromium 87.0.4280.63 to Chromium 87.0.4280.66.
mkarolin pushed a commit that referenced this pull request Nov 18, 2020
Updated patches from Chromium 87.0.4280.63 to Chromium 87.0.4280.66.
@mkarolin mkarolin added this to the 1.19.x - Nightly milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
2 participants