Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp injection only happens for http, https or ipfs #7169

Merged
merged 1 commit into from Nov 18, 2020

Conversation

petemill
Copy link
Member

Fixes the error about executeScript not being allowed for chrome:// URLs

Resolves brave/brave-browser#12738

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Fresh profile
  • Load Crypto Kitties
  • Ensure you get the expected crypto wallet notification bar

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussion in slack, we can nix the ipfs protocol check here.

also, more of a nit, as the handwritten regex works fine here, but in the interest of a tried and tested solution, wdyt about using URL? something like:

function isRemoteUrl (url: string) {
  const obj = new window.URL(url)
  return obj.protocol === 'http:' || obj.protocol === 'https:'
}

Fixes the error about executeScript not being allowed for chrome:// URLs
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@petemill petemill merged commit 9851e06 into master Nov 18, 2020
@petemill petemill deleted the dapp-inject-permissions-fix branch November 18, 2020 06:29
@petemill petemill self-assigned this Nov 18, 2020
@petemill petemill added this to the 1.19.x - Nightly milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants