Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Bitcoin.com NTP settings item #7184

Merged
merged 1 commit into from Nov 18, 2020
Merged

Removing Bitcoin.com NTP settings item #7184

merged 1 commit into from Nov 18, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 18, 2020

Fixes brave/brave-browser#12759

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Defined in issue

@ryanml ryanml added this to the 1.18.x - Beta milestone Nov 18, 2020
@ryanml ryanml requested review from AlexeyBarabash and a team November 18, 2020 15:04
@ryanml ryanml self-assigned this Nov 18, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Nov 18, 2020

test-browser failed on macOS due to several reward failures as per https://ci.brave.com/job/pr-brave-browser-sync-crash-1.18-macos/1/execution/node/251/log/. However, the reward failures are not related to this specific PR hence not blocking uplift.

12:04:05  3 tests failed:
12:04:05      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:399)
12:04:05      RewardsPromotionBrowserTest.ClaimViaPanel (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:203)
12:04:05      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:232)

test-browser failed on Win x64 due to several reward failures as per https://ci.brave.com/job/pr-brave-browser-sync-crash-1.18-windows/1/execution/node/247/log/. However, the reward failures are not related to this specific PR hence not blocking uplift.

12:40:10  2 tests failed:
12:40:10      RewardsBrowserTest.ActivateSettingsModal (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:121)
12:40:10      RewardsContributionBrowserTest.TipConnectedPublisherVerified (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:587)
12:40:10  1 test timed out:
12:40:10      RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:305)
12:40:10  1 test crashed:
12:40:10      RewardsBrowserTest.ToggleAutoContribute (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:132)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants