Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the QR code in Brave Rewards (brave://rewards) (uplift to 1.18.x) #7472

Merged
merged 1 commit into from Dec 18, 2020
Merged

Show the QR code in Brave Rewards (brave://rewards) (uplift to 1.18.x) #7472

merged 1 commit into from Dec 18, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 17, 2020 •
edited by kjozwiak

Uplift of #7413
Fixes brave/brave-browser#13159

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 17, 2020 17:09
@brave-builds brave-builds requested review from marshall, zenparsing and a team and removed request for a team December 17, 2020 17:09
@brave-builds brave-builds self-assigned this Dec 17, 2020
@brave-builds brave-builds added this to the 1.18.x - Release #2 milestone Dec 17, 2020
kjozwiak
kjozwiak approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 86d5ca2 into 1.18.x Dec 18, 2020
@kjozwiak kjozwiak deleted the pr7413_bsc-show-qr-code_1.18.x branch December 18, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@marshall marshall Awaiting requested review from marshall

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release #2
3 participants
@brave-builds @kjozwiak @brave-browser-releases