Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat decentralized DNS servers as available before first probe is completed #8212

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 10, 2021

Resolves brave/brave-browser#14513

This PR handles the case that DNS resolution failed because of falling back to non-secure DNS servers before the first probe of DoH server is completed and marked as available to use.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@yrliou yrliou added this to the 1.23.x - Nightly milestone Mar 10, 2021
@yrliou yrliou requested review from bbondy and mkarolin March 10, 2021 23:20
@yrliou yrliou requested a review from a team as a code owner March 10, 2021 23:20
@yrliou yrliou self-assigned this Mar 10, 2021
#include "net/dns/context_host_resolver.h"

#define ResolveContext BraveResolveContext
#include "../../../../net/dns/host_resolver.cc"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add #undef

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


#define GetDohServerAvailability virtual GetDohServerAvailability
#define NumAvailableDohServers virtual NumAvailableDohServers
#define BRAVE_RESOLVE_CONTEXT_H friend class BraveResolveContext;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could follow the format:

#define BRAVE_RESOLVE_CONTEXT_H\
 private: \
  friend class BraveResolveContext;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b20ad62.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src and patches changes LGTM

@yrliou
Copy link
Member Author

yrliou commented Mar 11, 2021

post-init has unrelated audit-dep failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants