Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fixes for Tab Groups option (uplift to 1.23.x) #8617

Merged
merged 1 commit into from Apr 23, 2021
Merged

[Android] Fixes for Tab Groups option (uplift to 1.23.x) #8617

merged 1 commit into from Apr 23, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 22, 2021 •
edited by kjozwiak

Uplift of #8614
Resolves brave/brave-browser#15453
Resolves brave/brave-browser#15450

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team April 22, 2021 20:37
@brave-builds brave-builds self-assigned this Apr 22, 2021
@brave-builds brave-builds added this to the 1.23.x - Release #3 milestone Apr 22, 2021
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 22, 2021
@kjozwiak
Copy link
Member

post-init failed due to audit-deps warnings as per https://ci.brave.com/job/pr-brave-browser-pr8614_android_tag_groups_fixes_1.23.x-post-init/1/execution/node/144/log/. However, this is a known warning/issue and unrelated to this specific PR.

kjozwiak
kjozwiak approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit dc17429 into 1.23.x Apr 23, 2021
@kjozwiak kjozwiak deleted the pr8614_android_tag_groups_fixes_1.23.x branch April 23, 2021 02:58
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
@StephenHeaps
Fix #8616: Swap Improvements (#8617)
61e7719 
* For Solana swaps, update `maxRetries` to 2 and `preflightCommitment` to `"processed"` for higher success rates with v4 API.

* Fix Solana Swaps not correctly showing loading state when creating a transaction.

* Fix possible race condition fetching price quote. Ignore response from prior request if sell amount changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.23.x - Release #3
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases