Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes shields extension showing disabled in background tabs. (uplift to 1.26.x) #9113

Merged
merged 1 commit into from Jun 15, 2021
Merged

Fixes shields extension showing disabled in background tabs. (uplift to 1.26.x) #9113

merged 1 commit into from Jun 15, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 14, 2021 •
edited by kjozwiak

Fixes brave/brave-browser#16362
Uplift of #9105

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner June 14, 2021 13:18
@brave-builds brave-builds requested a review from a team June 14, 2021 13:18
@brave-builds brave-builds self-assigned this Jun 14, 2021
@brave-builds brave-builds added this to the 1.26.x - Beta milestone Jun 14, 2021
@kjozwiak kjozwiak mentioned this pull request Jun 15, 2021
Closed
kjozwiak
kjozwiak approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.26.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#16362 (comment).

@kjozwiak kjozwiak merged commit 6d56595 into 1.26.x Jun 15, 2021
@kjozwiak kjozwiak deleted the pr9105_maxk-fix-shields-action_1.26.x branch June 15, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.26.x - Release
3 participants
@brave-builds @kjozwiak @brave-browser-releases