Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement Siri Shortcuts #2227

Closed
anthonypkeane opened this issue Jan 23, 2020 · 1 comment · Fixed by #3579
Closed

Implement Siri Shortcuts #2227

anthonypkeane opened this issue Jan 23, 2020 · 1 comment · Fixed by #3579
Assignees
@soner-yuksel
Labels
enhancement Epic: UI/UX feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.29

Comments

@anthonypkeane
Copy link
Collaborator

Description:

Spec: Search for "Share Data with Siri"
@anthonypkeane anthonypkeane added this to the 1.17 milestone Jan 23, 2020
@anthonypkeane anthonypkeane removed this from the 1.17 milestone May 14, 2020
@iccub iccub added this to the 1.25 milestone Mar 5, 2021
@kylehickinson kylehickinson changed the title Implement sharing data with Siri Implement Siri Shortcuts Mar 9, 2021
@iccub iccub modified the milestones: 1.25, 1.26 Mar 17, 2021
@soner-yuksel soner-yuksel mentioned this issue Apr 26, 2021
Merged
7 tasks
@soner-yuksel soner-yuksel self-assigned this Apr 28, 2021
@iccub iccub modified the milestones: 1.26, 1.27 May 5, 2021
@iccub iccub modified the milestones: 1.27, 1.28 May 26, 2021
@iccub iccub modified the milestones: 1.28, 1.29 Jun 25, 2021
iccub added a commit that referenced this issue Jul 16, 2021
@soner-yuksel @iccub
Fix #2227: Siri Shortcuts (Activity/Custom Intents) (#3579)
3a040a8 
Co-authored-by: Michał Buczek <michal.buczek@protonmail.com>
@srirambv
Copy link
Contributor

Verification passed on iPad Pro with iOS 14.6 running 1.29(21.07.28.22)
  • Verified test plan from Feature: #2227: Siri Shortcuts (Activity/Custom Intents) #3579
  • Verified new setting option for Siri Shortcuts is shown under General settings
  • Verified Add to Siri shortcuts are shown and disabled by default
  • Verified able to add Siri shortcuts via settings menu
  • Verified saying the voice command performs the specific actions
  • Verified able to delete a Siri shortcut via Settings menu
  • Verified Open Settings links to Device Settings app and selects Brave
  • Verified voice commands work for both normal and private tabs
  • Verified when Brave News / VPN is not enabled it opens up the specific setting page
  • Verified when opt-ed into Brave News, voice command opens a new tab and opens Brave News feed
  • Verified voice command for New tab/Private tab works as expected
  • Verified Brave Playlist voice command only opens the playlist but doesn't play any video from the list
  • Verified able to access Siri voice commands via lock screen/home screen and the action is performed correctly
  • Verified typing in the command in Siri suggestions performs the commands correctly and launches Brave
  • Verified clicking on Play button on Siri Shortcuts performs the task correctly and launches Brave
Settings Siri Shortcuts Add Shortcut Edit Shortcut Delete Shortcut Siri Shortcuts Cards
image image image image image image
iPad.Pro.Siri.Search.Suggestions.MP4
iPad.Pro.Siri.Shortcuts.MP4
Verification passed on iPhone 7+ with iOS 14.5.1 running 1.29(21.07.28.22)
  • Verified test plan from Feature: #2227: Siri Shortcuts (Activity/Custom Intents) #3579
  • Verified new setting option for Siri Shortcuts is shown under General settings
  • Verified Add to Siri shortcuts are shown and disabled by default
  • Verified able to add Siri shortcuts via settings menu
  • Verified saying the voice command performs the specific actions
  • Verified able to delete a Siri shortcut via Settings menu
  • Verified Open Settings links to Device Settings app and selects Brave
  • Verified voice commands work for both normal and private tabs
  • Verified when Brave News / VPN is not enabled it opens up the specific setting page
  • Verified when opt-ed into Brave News, voice command opens a new tab and opens Brave News feed
  • Verified voice command for New tab/Private tab works as expected
  • Verified Brave Playlist voice command only opens the playlist but doesn't play any video from the list
  • Verified able to access Siri voice commands via lock screen/home screen and the action is performed correctly
  • Verified typing in the command in Siri suggestions performs the commands correctly and launches Brave
  • Verified clicking on Play button on Siri Shortcuts performs the task correctly and launches Brave
Settings Siri Shortcuts Add Shortcut Edit Shortcut Delete Shortcut Siri Shortcuts Cards
image image image image image image
iPhone.7+.Siri.Shortcuts.MP4
iPhone.Siri.Search.Suggestions.MP4
Verification passed on iPhone XR with iOS 13.5 running 1.29(21.07.28.22)
  • Verified test plan from Feature: #2227: Siri Shortcuts (Activity/Custom Intents) #3579
  • Verified new setting option for Siri Shortcuts is shown under General settings
  • Verified Add to Siri shortcuts are shown and disabled by default
  • Verified able to add Siri shortcuts via settings menu
  • Verified saying the voice command performs the specific actions
  • Verified able to delete a Siri shortcut via Settings menu
  • Verified Open Settings links to Device Settings app and selects Brave
  • Verified voice commands work for both normal and private tabs
  • Verified when Brave News / VPN is not enabled it opens up the specific setting page
  • Verified when opt-ed into Brave News, voice command opens a new tab and opens Brave News feed
  • Verified voice command for New tab/Private tab works as expected
  • Verified Brave Playlist voice command only opens the playlist but doesn't play any video from the list
  • Verified able to access Siri voice commands via lock screen/home screen and the action is performed correctly
  • Verified typing in the command in Siri suggestions performs the commands correctly and launches Brave
  • Verified clicking on Play button on Siri Shortcuts performs the task correctly and launches Brave
Settings Siri Shortcuts Add Shortcut Edit Shortcut Delete Shortcut Siri Shortcuts Cards
image image image image image image
iPhone.XR.Siri.Suggestions.MP4
iPhone.XR.Siri.Shortcuts.MP4

@kjozwiak kjozwiak mentioned this issue Aug 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
enhancement Epic: UI/UX feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.29
Development

Successfully merging a pull request may close this issue.

Feature: #2227: Siri Shortcuts (Activity/Custom Intents) brave/brave-ios
4 participants
@soner-yuksel @iccub @anthonypkeane @srirambv