Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Incorrect Twitter icons is shown on when using SR build #2722

Closed
srirambv opened this issue Jul 17, 2020 · 1 comment · Fixed by #3125
Closed

Incorrect Twitter icons is shown on when using SR build #2722

srirambv opened this issue Jul 17, 2020 · 1 comment · Fixed by #3125
Assignees
@kylehickinson
Labels
bug Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@srirambv
Copy link
Contributor

Description:

Incorrect Twitter icons is shown on when using SR build

Steps to Reproduce

  1. Install SR build
  2. Visit a verified twitter account
  3. Open Rewards panel, shows Twitter icon which is a custom icon from SR build
  4. Add the twitter page as bookmark/favourite, same SR custom icon is used

Actual result:
Incorrect Twitter icons is shown on when using SR build

Expected result:
Should use publisher icon if available

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.19(20..07.16.15)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@srirambv srirambv added this to the 1.20 milestone Jul 17, 2020
@anthonypkeane anthonypkeane modified the milestones: 1.20, 1.21 Jul 29, 2020
@iccub iccub modified the milestones: 1.22, 1.23 Oct 21, 2020
@kylehickinson kylehickinson self-assigned this Dec 7, 2020
kylehickinson added a commit that referenced this issue Dec 7, 2020
@kylehickinson
Fix #2722: Only use URP custom icons for matching URLs
7e92060
@kylehickinson kylehickinson mentioned this issue Dec 8, 2020
Merged
7 tasks
kylehickinson added a commit that referenced this issue Dec 8, 2020
@kylehickinson
Fix #2722: Only use URP custom icons for matching URLs (#3125)
bdd1802
@srirambv
Copy link
Contributor Author

  • Verification passed on iPhone XR with iOS 13.5 running 1.23(21.2.10.18)

  • Verification passed on iPhone 7+with iOS 14.4running 1.23(21.2.10.18)

  • Verification passed on iPad Pro with iOS 12.4.1running 1.23(21.2.10.18)
    image

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #2722: Only use URP custom icons for matching URLs brave/brave-ios
4 participants
@kylehickinson @iccub @anthonypkeane @srirambv