Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Reopening new tabs increase app memory a lot #3867

Closed
iccub opened this issue Jun 29, 2021 · 1 comment · Fixed by #3896
Closed

Reopening new tabs increase app memory a lot #3867

iccub opened this issue Jun 29, 2021 · 1 comment · Fixed by #3896
Assignees
@Brandon-T
Labels
bug Epic: NTP QA/No release-notes/include
Milestone
1.29

Comments

@iccub
Copy link
Collaborator

iccub commented Jun 29, 2021

Description:

Steps to Reproduce

  1. Open a tab
  2. Close a tab, open new tab
  3. Repeat 10 times

Actual result:
A lot of memory is used

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.29 milestone Jun 29, 2021
@iccub iccub added QA/Yes and removed QA/No labels Jul 7, 2021
@Brandon-T Brandon-T mentioned this issue Jul 7, 2021
Merged
7 tasks
Brandon-T added a commit that referenced this issue Jul 12, 2021
@Brandon-T @kylehickinson
Fix #3867 - Fixes using lots of RAM for NTP (#3896)
8316251 
* Make NTP images load at runtime and not cache to reduce memory pressure when tons of tabs are open.

Co-authored-by: Kyle Hickinson <kylehickinson@users.noreply.github.com>
Brandon-T added a commit that referenced this issue Jul 12, 2021
@Brandon-T @kylehickinson
Fix #3867 - Fixes using lots of RAM for NTP (#3896)
0f549b8 
* Make NTP images load at runtime and not cache to reduce memory pressure when tons of tabs are open.

Co-authored-by: Kyle Hickinson <kylehickinson@users.noreply.github.com>
@srirambv
Copy link
Contributor

Marking as QA/No as this one requires building the code and testing.

@kjozwiak kjozwiak mentioned this issue Aug 10, 2021
Closed
KacperWybranski pushed a commit to KacperWybranski/brave-ios that referenced this issue Sep 4, 2021
@Brandon-T @kylehickinson @KacperWybranski
Fix brave#3867 - Fixes using lots of RAM for NTP (brave#3896)
5a5ef72 
* Make NTP images load at runtime and not cache to reduce memory pressure when tons of tabs are open.

Co-authored-by: Kyle Hickinson <kylehickinson@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: NTP QA/No release-notes/include
Projects
None yet
Milestone
1.29
Development

Successfully merging a pull request may close this issue.

Fix #3867 - Fixes using lots of RAM for NTP brave/brave-ios
4 participants
@Brandon-T @kjozwiak @iccub @srirambv