Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

App launches in light mode when Private Browsing Only mode is enabled #3936

Closed
kylehickinson opened this issue Jul 16, 2021 · 1 comment · Fixed by #3937
Closed

App launches in light mode when Private Browsing Only mode is enabled #3936

kylehickinson opened this issue Jul 16, 2021 · 1 comment · Fixed by #3937
Assignees
@kylehickinson
Labels
bug Epic: UI/Theme QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.30

Comments

@kylehickinson
Copy link
Collaborator

Description:

When you have Private Browsing Only mode enabled the app is currently restricted to dark mode, however on a fresh launch it will be in light mode anyways

Steps to Reproduce

  1. Enable PBO
  2. Kill app from app tray
  3. Re-launch app

Actual result: Launches in light mode
Expected result: Launch in dark mode since PBO only supports dark mode currently
Reproduces how often: Easily
Brave Version: Live (1.28)
@kylehickinson kylehickinson self-assigned this Jul 16, 2021
@kylehickinson kylehickinson added this to the 1.30 milestone Jul 16, 2021
kylehickinson added a commit that referenced this issue Jul 16, 2021
@kylehickinson
Fix #3936: Set the correct theme based on PBO on launch
707befd
@kylehickinson kylehickinson mentioned this issue Jul 16, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jul 16, 2021
@kylehickinson
Fix #3936: Set the correct theme based on PBO on launch (#3937)
5c51171
@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.30(21.8.5.11)

  • Verified PB only mode launches on dark mode as expected
iPhone.XR.PB.only.mode.MP4

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.30(21.8.5.11)

  • Verified PB only mode launches on dark mode as expected
iPhone.7+.PB.only.mode.MP4

Verification passed on iPad Pro with iOS 14.6 running 1.30(21.8.5.11)

  • Verified PB only mode launches on dark mode as expected
iPad.Pro.PB.only.mode.MP4

@srirambv srirambv mentioned this issue Aug 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: UI/Theme QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.30
Development

Successfully merging a pull request may close this issue.

Fix #3936: Set the correct theme based on PBO on launch brave/brave-ios
2 participants
@kylehickinson @srirambv