Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update search engine defaults for CA / DE / FR / GB / US #4221

Closed
iccub opened this issue Sep 24, 2021 · 3 comments · Fixed by #4282, #4286 or #4316
Closed

Update search engine defaults for CA / DE / FR / GB / US #4221

iccub opened this issue Sep 24, 2021 · 3 comments · Fixed by #4282, #4286 or #4316
Assignees
@iccub
Labels
enhancement Epic: Search QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.32

Comments

@iccub
Copy link
Collaborator

iccub commented Sep 24, 2021 •
edited by bsclifton
Loading

Update search engine defaults for:

Canada (CA)
Germany (DE)
France (FR)
Great Britain (GB)
United States (US)

Desktop issue tracked here brave/brave-browser#18331

Please see details here: https://github.com/brave/internal/issues/816
@iccub iccub added enhancement blocked: needs info Needs further information before work can commence QA/Yes Epic: Search labels Sep 24, 2021
@iccub iccub added this to the icebox milestone Sep 24, 2021
@iccub iccub changed the title Update search engine defaults for CA / DE / FR / GB / US2 Update search engine defaults for CA / DE / FR / GB / US Sep 24, 2021
@iccub iccub mentioned this issue Sep 24, 2021
Closed
@bsclifton bsclifton mentioned this issue Sep 30, 2021
Closed
@bsclifton
Copy link
Member

@iccub should be ready to start - see internal issue @anthonypkeane created 😄

@bsclifton bsclifton modified the milestones: icebox, 1.32 Sep 30, 2021
@iccub
Copy link
Collaborator Author

iccub commented Sep 30, 2021

i forgot we had this ticket tbh :) will get it done tomorrow

@iccub iccub removed the blocked: needs info Needs further information before work can commence label Oct 1, 2021
@iccub iccub mentioned this issue Oct 5, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Oct 5, 2021
@iccub
Fix #4221: Update Search Engines.
0fefe2c
iccub added a commit that referenced this issue Oct 5, 2021
@iccub
Fix #4221: Update Search Engines. (#4282)
8f8b378
@iccub iccub mentioned this issue Oct 5, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Oct 6, 2021
@iccub
Ref #4221: Exclude Brave Search from onboarding. (#4286)
6047042
@iccub iccub modified the milestones: 1.32.1, 1.32 Oct 13, 2021
iccub added a commit that referenced this issue Oct 13, 2021
@iccub
Ref #4221: Set correct preference value for BraveSearch default.
af03ba8
@iccub iccub mentioned this issue Oct 13, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Oct 13, 2021
@iccub
Ref #4221: Set correct preference value for BraveSearch default. (#4316)
c748b1f
iccub added a commit that referenced this issue Oct 13, 2021
@iccub
Fix #4221: Update Search Engines. (#4282)
e449b99
iccub added a commit that referenced this issue Oct 13, 2021
@iccub
Ref #4221: Exclude Brave Search from onboarding. (#4286)
f1aefd3
iccub added a commit that referenced this issue Oct 13, 2021
@iccub
Ref #4221: Set correct preference value for BraveSearch default. (#4316)
cbe0b5a
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8 running 1.32(21.10.13.11)

  • Verification notes here

Verification passed on iPhone XR with iOS 15.0.1 running 1.32(21.10.13.11)

  • Verification notes here

Verification passed on iPad Pro with iOS 15 Beta 3 running 1.32(21.10.13.11)

  • Verification notes here

@srirambv srirambv mentioned this issue Oct 14, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Search QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.32
3 participants
@bsclifton @iccub @srirambv