This repository has been archived by the owner on May 10, 2024. It is now read-only.
Ref #4221: Exclude Brave Search from onboarding. #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
commented
Oct 5, 2021
| @@ -25,6 +25,15 @@ class InitialSearchEngines { | |||
| case .ecosia: return "ecosia.org/opensearch" | |||
| } | |||
| } | |||
|
|
|||
| func excludedFromOnboarding(for locale: Locale) -> Bool { | |||
There was a problem hiding this comment.
@kylehickinson removing it didn't last long :D
The product team want to keep Brave Search excluded from onboarding for all regions now
Brandon-T
approved these changes
Oct 5, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #4221
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement