Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Tx Confirmation presented over Asset Detail dismisses automatically #7200

Closed
StephenHeaps opened this issue Apr 4, 2023 · 2 comments · Fixed by #7203
Closed

Tx Confirmation presented over Asset Detail dismisses automatically #7200

StephenHeaps opened this issue Apr 4, 2023 · 2 comments · Fixed by #7203
Assignees
@StephenHeaps
Labels
bug Epic: Brave Wallet QA Pass - iPad QA/Yes release-notes/include
Milestone
1.49.1

Comments

@StephenHeaps
Copy link
Contributor

Description:

Transaction confirmation view dismisses automatically when presented over asset detail view

Steps to Reproduce

  1. Visit an asset detail page via Portfolio
  2. Tap Send/Swap and create the transaction
  3. Observe tx confirmation is shown, but dismisses automatically

Actual result:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-04-04.at.12.10.46.mp4

Expected result:

Does not dismiss automatically

Reproduces how often:

Easily reproduced

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@StephenHeaps
Copy link
Contributor Author

StephenHeaps commented Apr 4, 2023 •
edited
Loading

Similar to regression of #6460

@StephenHeaps StephenHeaps mentioned this issue Apr 4, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Apr 5, 2023
@StephenHeaps
Fix #7200: Tx Confirmation auto-dismisses after creating tx via asset…
00dd731 
… details (#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
Brandon-T pushed a commit that referenced this issue Apr 11, 2023
@StephenHeaps @Brandon-T
Fix #7200: Tx Confirmation auto-dismisses after creating tx via asset…
96ba956 
… details (#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
@iccub iccub added this to the 1.50 milestone Apr 11, 2023
@iccub iccub added the QA/Yes label Apr 11, 2023
iccub pushed a commit that referenced this issue Apr 12, 2023
@StephenHeaps @iccub
Fix #7200: Tx Confirmation auto-dismisses after creating tx via asset…
5ee8eb3 
… details (#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
@iccub iccub modified the milestones: 1.50, 1.49.1 Apr 12, 2023
@srirambv
Copy link
Contributor

Verification passed on iPad Pro with iOS 16.5 beta running 1.49.1(23.4.12.18)

  • Verified steps from #7203
  • Verified creating a new wallet shows enable biometric modal
  • Verified restoring a wallet shows enable biometric modal
  • Verified dismissing biometric doesn't cause any issue during wallet creation or restore
  • Verified Bridge to Aurora shows the popup correctly each time
  • Verified selecting Do not show again on the Bridge to Aurora modal doesn't show it again
  • Verified Buy/Send/Swap modal is not auto-dismissed when changing network in respective screen
  • Verified transaction confirmation screen is not auto-dismissed and shows details as expected for both send and swap transactions
7200.MP4

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7200: Tx Confirmation auto-dismisses after creati…
ad87a90 
…ng tx via asset details (brave/brave-ios#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
bug Epic: Brave Wallet QA Pass - iPad QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.1
Development

Successfully merging a pull request may close this issue.

Fix #7200: Tx Confirmation auto-dismisses after creating tx via asset details brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv