Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

VPN Restore Infinite Loading #7875

Closed
anthonypkeane opened this issue Aug 14, 2023 · 1 comment · Fixed by #7951
Closed

VPN Restore Infinite Loading #7875

anthonypkeane opened this issue Aug 14, 2023 · 1 comment · Fixed by #7951

Comments

@anthonypkeane
Copy link

anthonypkeane commented Aug 14, 2023

Description:

https://bravesoftware.slack.com/archives/CC5SA8CCB/p1691925926377529

Per Watson, it seems pressing restore just shows a spinner that doesn't go away

This looks like a problem for user who never purchased but restoring from Buy Screen.

@soner-yuksel soner-yuksel self-assigned this Aug 24, 2023
@soner-yuksel soner-yuksel changed the title VPN Restore button bug VPN Restore Infinite Loading Aug 24, 2023
Brandon-T pushed a commit that referenced this issue Aug 25, 2023
- Handling restore completed empty restorations and timer for action
@iccub iccub added this to the 1.58 milestone Aug 28, 2023
@hffvld
Copy link
Collaborator

hffvld commented Sep 25, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.22.13)
BraveCore: 1.58.129 (117.0.5938.88)

OR

Filed follow-up issue #8154

Fresh install. No active subscription

STEPS:

  1. Launch Brave
  2. Three-dot menu > VPN
  3. Tap the Restore button > Verify the error message

ACTUAL RESULTS:

  • Verified when no active subscription, tapping the Restore button shows an error message after ~10 - 20 seconds of waiting
  • Verified that no infinite loading spinner was observed when tapping Restore button

1
1

No active VPN subscription

2023-09-19_16-32-46.mp4
Restore active VPN subscription

STEPS:

  1. Launch Brave
  2. Three-dot menu > VPN
  3. Purchase monthly or yearly VPN subscription > Install VPN Profile
  4. Confirm that VPN is working
  5. Uninstall and reinstall Brave
  6. Launch Brave > Three-dot menu > VPN > Tap Restore > Verify

ACTUAL RESULTS:

  • Verified when a user has an active subscription, tapping the Restore button allows to active VPN
  • Verified that no infinite loading spinner was observed when tapping the Restore button

2023-09-25_15-27-43.mp4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…os#7951)

- Handling restore completed empty restorations and timer for action
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants