"Block Cookie Consent Notices" toggle switch changed to ON after Brave upgrade to 1.57 if it was set to OFF before the upgrade

[hffvld]

Description:

When the user set Block Cookie Consent Notices setting to OFF while on Brave 1.56 or lower and then upgrades to Brave 1.57, Block Cookie Consent Notices toggle switch is updated to ON by itself.

Steps to Reproduce

1. Install Brave 1.56
2. Launch Brave and go through the onboarding flow until landed on NTP
3. Close and relaunch Brave until you see the Cookie consent notice pop-up
4. Select No thanks
5. Three-dot menu > Settings > Brave Shields & Privacy
6. Confirm that the Block Cookie Consent Notices toggle switch is OFF
7. Upgrade Brave to build 1.57 and launch it
8. Three-dot menu > Settings > Brave Shields & Privacy > Observe that Block Cookie Consent Notices is ON now

Actual result:

Block Cookie Consent Notices toggle switch changed to ON after Brave upgrade to 1.57 if it was set to OFF before the upgrade.

Cookies_upgrade_OFF.mov

Expected result:

Block Cookie Consent Notices toggle switch must stay OFF after Brave upgrade to 1.57 if it was set to OFF before the upgrade since that was the user's choice.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.57 (23.8.21.22)
BraveCore: 1.57.47 (116.0.5845.96)

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? NA
• Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.6]

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

cc @cuba @iccub

[hffvld]

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.0]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57 (23.8.24.22)
BraveCore: 1.57.53 (116.0.5845.114)

---

STEPS:
Followed the steps from #7920 (comment)

ACTUAL RESULTS:

• Verified that Block Cookie Consent Notices toggle switch was still disabled after the upgrade to build 1.57 was done
• Verified that no regression occurred when Block Cookie Consent Notices toggle switch was ON before the upgrade
• Verified that Block Cookie Consent Notices setting is working respectively to the toggle switch position

---

iPhone

Cookies_upgrade_OFF_iphone.mov

iPad

Cookies_upgrade_OFF_ipad.mov