Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Fix #2694: Brave Ads state-level targeting upgrade crash #2709

Merged
merged 1 commit into from Jul 9, 2020
Merged

Fix #2694: Brave Ads state-level targeting upgrade crash #2709

merged 1 commit into from Jul 9, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 7, 2020

Summary of Changes

This pull request fixes #2694

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@tmancey tmancey self-assigned this Jul 7, 2020
@tmancey tmancey changed the base branch from development to brave-core-1.12.x July 7, 2020 18:54
@kylehickinson kylehickinson changed the title Fix #2694: Brave Ads state-level targeting crash Fix #2694: Brave Ads state-level targeting upgrade crash Jul 7, 2020
@kylehickinson kylehickinson merged commit 5f3fd91 into brave-core-1.12.x Jul 9, 2020
@kylehickinson kylehickinson deleted the brave-core-1.12.x-state-level-targeting-fixes branch July 9, 2020 15:05
kylehickinson pushed a commit that referenced this pull request Jul 9, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
9f4aba8
kylehickinson pushed a commit that referenced this pull request Jul 27, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
db9ea62
kylehickinson pushed a commit that referenced this pull request Jul 27, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
4eb7b2c
kylehickinson pushed a commit that referenced this pull request Aug 5, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
638dee4
kylehickinson pushed a commit that referenced this pull request Aug 13, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
0e3fb79
kylehickinson pushed a commit that referenced this pull request Aug 14, 2020
@tmancey @kylehickinson
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
f4c213d
Brandon-T added a commit that referenced this pull request Sep 25, 2020
@Brandon-T
Fix #2694: Brave Ads state-level targeting upgrade crash (#2709)
35923f8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@tmancey tmancey

Labels
Epic: Ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixes state-level targeting crash after upgrade on iOS
2 participants
@tmancey @kylehickinson