Fix: #4273 Built Send Crypto Screen

[nuo-xu]

Summary of Changes

• Built Send Crypto Screen UI
• Integrated the screen with token fetching/selection/balance

This pull request fixes #4273

Submitter Checklist:

• Unit Tests are updated to cover new or changed functionality
• User-facing strings use NSLocalizableString()

Screenshots:

Reviewer Checklist:

• Issues include necessary QA labels:
  • QA/(Yes|No)
  • bug / enhancement
• Necessary security reviews have taken place.
• Adequate unit test coverage exists to prevent regressions.
• Adequate test plan exists for QA to validate (if applicable).
• Issue and pull request is assigned to a milestone (should happen at merge time).

[kylehickinson]

Set a font on this instead, brave.clipboard is a custom SF Symbol so no need to make it resizable/aspect-fit/frame modifiers

[kylehickinson]

Don't think you have to re-fetch asset balance when an account is added/removed as long as the selected account still exists. Maybe add a check here to see if selected account exists in in the keyring.accountInfos

[nuo-xu]

Don't think you have to re-fetch asset balance when an account is added/removed as long as the selected account still exists. Maybe add a check here to see if selected account exists in in the keyring.accountInfos

I wasn't too sure what this protocol is for that's why I fetch the assets there. But after your explanation, i think fetch assets in selectedAccountChanged is sufficient.

[kylehickinson]

use SnapKit instead

[kylehickinson]

private let captureSession = AVCaptureSession().then {
  $0.sessionPreset = .high
}

[kylehickinson]

isAccessibilityElement = false

[nuo-xu]

isAccessibilityElement = false

it's right below at 159 😀

[kylehickinson]

As per conversation: do something like this

struct WalletScannerView: View {
  @Binding var address: String
  @State private var isErrorPresented: Bool = false
  @Environment(\.presentationMode) @Binding private var presentationMode
  
  var simulatorBody: some View {
    
  }
  
  var body: some View {
    NavigationView {
    #if targetEnvironment(simulator)
    Text("Unable to scan on simulator")
      .onAppear {
        DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
          address = ""
          presentationMode.dismiss()
        }
      }
    #else
    _WalletScannerView(address: _address)
      .ignoresSafeArea()
      .alert()
    #endif
    }
    .toolbar {
      ToolbarItemGroup(placement: .cancellationAction) {
        Text("")
      }
    }
  }
}

[kylehickinson]

These can be all combined into a simpler flow

if !isFinishScanning, 
    let stringValue = (metadataObjects.first as? AVMetadataMachineReadableCodeObject)?.stringValue, 
    stringValue.isAddress {
  address = stringValue
  dismiss()
} else {
  isErrorPresented = true
}
isFinishScanning = true

Are we treating non-address as errors as well? Are we going to have a special error message for that?

[nuo-xu]

I checked other existed scanners they don't have output validation. We can treat it as invalid data to have a popup so that user knows the scan did happen but the data is wrong.