Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8056: Update P3A callout text. #8083

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix #8056: Update P3A callout text. #8083

merged 1 commit into from
Sep 18, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Sep 18, 2023

Summary of Changes

This pull request fixes #8056

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub added this to the 1.58 milestone Sep 18, 2023
@iccub iccub requested a review from a team as a code owner September 18, 2023 16:59
@iccub iccub merged commit e2b1b77 into development Sep 18, 2023
8 checks passed
@iccub iccub deleted the bugfix/8056 branch September 18, 2023 17:48
iccub added a commit that referenced this pull request Sep 19, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small P3A Onboarding text update
2 participants