Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release #69

Merged
merged 6 commits into from
Dec 2, 2021
Merged

Production Release #69

merged 6 commits into from
Dec 2, 2021

Conversation

tackley
Copy link
Collaborator

@tackley tackley commented Dec 2, 2021

… login

This is not totally ideal as when you login, it loses the room name you were trying to connect to, so you need to go back to slack and click the link again :(  But it's better than getting stuck, and at least you can start a 1:1 room.

Re #16
give `/talk` non-subscribers options to create the call anyway and to login
@tackley tackley requested a review from mrose17 December 2, 2021 13:54
@tackley tackley linked an issue Dec 2, 2021 that may be closed by this pull request
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winner!

@tackley tackley merged commit 8c5878e into prod Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

give /talk non-subscribers options to create the call anyway and to login
2 participants