Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

check for valid data before upgrading and assign defaults after cleaning #3537

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Aug 29, 2016

Fixes #3550

Auditors: @bbondy @bsclifton

@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

Is there an issue for this? If not please post and update PR. Also to ensure it is tested the issue should be marked in the 0.11.6 milestone.

@bridiver
Copy link
Collaborator Author

@bsclifton can you create an issue for the original problem you had?

@bsclifton
Copy link
Member

bsclifton commented Aug 30, 2016

@bridiver beat me to creating an issue, but I captured some good steps 😄

Check out the issue and STR here

@bsclifton
Copy link
Member

bsclifton commented Aug 30, 2016

To verify the fix

  • Ensure all Brave instances are closed
  • Download session-store-1_bsc0.11.1.zip
  • Unzip / move this session file to the appropriate location (Mac is ~/Libraries/Application\ Support/brave/), making sure to rename it as session-store-1
  • Install a version of Brave which has the fix
  • Launch into Brave and inspect the browser developer tools (Shift + F8)

@bbondy bbondy merged commit 4405284 into master Aug 30, 2016
@bbondy
Copy link
Member

bbondy commented Aug 30, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants