This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
only update the menu when bookmarks or closed tabs change #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
force-pushed
the
menu-updates
branch
from
91414dd
to
8b0e958
Compare
|
cc @bsclifton |
|
++ thanks |
| @@ -363,13 +365,17 @@ const createHistorySubmenu = (CommonMenu) => { | |||
| return submenu | |||
| } | |||
|
|
|||
| const createBookmarksSubmenu = (CommonMenu) => { | |||
| const isCurrentLocationBookmarked = () => { | |||
There was a problem hiding this comment.
Super nice cleanup with this method 😄 The previous code was hacky (because it could be changed in appStore OR in the navigationBar control) and there were definitely ways to cause it to fail (ex: shows checked but its not bookmarked)
|
Great job 😄 ++ |
This was referenced Sep 8, 2016
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan:
Add bookmark
Bookmark indicator
Last closed Frame
Language
State
Fix #3782