You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're trying to work out the best way to convert our Leo Icon library to SF Symbols on iOS. @kylehickinson provided a template for monochrome icons and we've configured this in #250.
This has a number of limitations
Only works for monochrome icons
Doesn't work for a bunch of complex icons.
As it stands, our theory is that SF Symbols always use a nonzero fill rule, instead of the evenodd fill rule which all of our Leo Icons use. Note: this is only a theory, but it does reflect the problems we're seeing, and we can reproduce the issue outside of SF Symbols by changing the fill-rules on one of our SVGs from evenodd to nonzero.
We tried using svg-path-reverse to reverse some/all of the paths in the broken SVGs. It helps for some SVG Icons but I couldn't get it to work with news-filmandtv.svg.
The text was updated successfully, but these errors were encountered:
Let's figure out a github action where something checks for changes on main branch when /icons changes, updates https://github.com/brave/leo-sf-symbols/ with latest generated symbols.re out a github action where something checks for changes on main branch when /icons changes, updates https://github.com/brave/leo-
We're trying to work out the best way to convert our Leo Icon library to SF Symbols on iOS. @kylehickinson provided a template for monochrome icons and we've configured this in #250.
This has a number of limitations
As it stands, our theory is that SF Symbols always use a
nonzero
fill rule, instead of theevenodd
fill rule which all of our Leo Icons use. Note: this is only a theory, but it does reflect the problems we're seeing, and we can reproduce the issue outside of SF Symbols by changing thefill-rule
s on one of our SVGs fromevenodd
tononzero
.A helpful primer for SVG
fill-rules
is https://www.sitepoint.com/understanding-svg-fill-rule-property/We tried using svg-path-reverse to reverse some/all of the paths in the broken SVGs. It helps for some SVG Icons but I couldn't get it to work with
news-filmandtv.svg
.The text was updated successfully, but these errors were encountered: