Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons]: iOS Icon Support #255

Closed
fallaciousreasoning opened this issue Mar 30, 2023 · 3 comments · Fixed by #259
Closed

[Icons]: iOS Icon Support #255

fallaciousreasoning opened this issue Mar 30, 2023 · 3 comments · Fixed by #259
Assignees

Comments

@fallaciousreasoning
Copy link
Collaborator

We're trying to work out the best way to convert our Leo Icon library to SF Symbols on iOS. @kylehickinson provided a template for monochrome icons and we've configured this in #250.

This has a number of limitations

  • Only works for monochrome icons
  • Doesn't work for a bunch of complex icons.

As it stands, our theory is that SF Symbols always use a nonzero fill rule, instead of the evenodd fill rule which all of our Leo Icons use. Note: this is only a theory, but it does reflect the problems we're seeing, and we can reproduce the issue outside of SF Symbols by changing the fill-rules on one of our SVGs from evenodd to nonzero.

A helpful primer for SVG fill-rules is https://www.sitepoint.com/understanding-svg-fill-rule-property/

We tried using svg-path-reverse to reverse some/all of the paths in the broken SVGs. It helps for some SVG Icons but I couldn't get it to work with news-filmandtv.svg.

@petemill
Copy link
Member

petemill commented Apr 5, 2023

LEt's create a separate repo that the generation script can dump the sf symbol files in

@petemill
Copy link
Member

petemill commented Apr 12, 2023

Let's figure out a github action where something checks for changes on main branch when /icons changes, updates https://github.com/brave/leo-sf-symbols/ with latest generated symbols.re out a github action where something checks for changes on main branch when /icons changes, updates https://github.com/brave/leo-

@fallaciousreasoning
Copy link
Collaborator Author

https://github.com/brave/leo-sf-symbols now has a Github Action for automatic updates. However, it isn't being triggered automatically (that will come in #259).

You can manually trigger an update from here https://github.com/brave/leo-sf-symbols/actions/workflows/update.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants