Add action for auto updating symbols #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallaciousreasoning
requested review from
petemill and
AlanBreck
as code owners
fallaciousreasoning
had a problem deploying
to
staging
GitHub Actions
Failure
kim0
approved these changes
Apr 19, 2023
.github/workflows/sf-symbols.yml
Outdated
| steps: | ||
| - uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.LEO_SF_SYMBOLS_ACCESS_TOKEN }} |
There was a problem hiding this comment.
Don't really like tokens, but I don't think we can trigger another repo without it.
cc @mihaiplesa to check and maybe create the token as I don't have permission on that repo.
|
@fallaciousreasoning CI seems to need a fix too |
fallaciousreasoning
temporarily deployed
to
staging
GitHub Actions
Inactive
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://259.pr.leo.bravesoftware.com/ |
mihaiplesa
approved these changes
Apr 19, 2023
|
I'm going to merge - dunno if it's going to work 😆 |
|
@fallaciousreasoning I've added the needed secret and verified triggering the |
|
Wonderful, thanks @kim0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
@kim0 I've created an action in the Leo SF Symbols repo which I want to run on deploy - would you mind having a look at this and letting me know if you think it's the right approach (and if it is, setting up the
LEO_SF_SYMBOLS_ACCESS_TOKENas a token which will let the action get triggered).I haven't done much with GH Actions before so I might be going in the completely wrong direction.