This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Implement subclass of SSLCertificateViewerMac #175

Closed

darkdh opened this issue Apr 5, 2017 · 1 comment

Assignees

Member

darkdh commented Apr 5, 2017

We currently new a instance of this base class. It will cause a crash from Debug build

- (void)sheetDidEnd:(NSWindow*)parent
         returnCode:(NSInteger)returnCode
            context:(void*)context {
  NOTREACHED();  // Subclasses must implement this.
}

in chrome/browser/ui/certificate_viewer_mac.mm

reference
chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.h and chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.mm

The text was updated successfully, but these errors were encountered:

darkdh self-assigned this

Member Author

darkdh commented May 9, 2017

fixed by d534ffd

darkdh closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.