Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

C67: use system python for update-external-binaries.py #598

Open
ltilve opened this issue May 18, 2018 · 2 comments
Open

C67: use system python for update-external-binaries.py #598

ltilve opened this issue May 18, 2018 · 2 comments

Comments

@ltilve
Copy link
Contributor

ltilve commented May 18, 2018

We are hitting a SSL problem while running npm run init just on our Windows envs at https://git.igalia.com/chromium/muon/src/master/script/update-external-binaries.py#L61

  File "src/electron/script/update-external-binaries.py", line 66, in <module>
  File "src/electron/script/update-external-binaries.py", line 32, in main
  File "src/electron/script/update-external-binaries.py", line 50, in download_and_unzip
  File "src/electron/script/update-external-binaries.py", line 61, in download_framework
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\electron\script\lib\util.py", line 81, in download
    web_file = urllib2.urlopen(url)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 127, in urlopen
    return _opener.open(url, data, timeout)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 410, in open
    response = meth(req, response)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 442, in error
    result = self._call_chain(*args)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 629, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 404, in open
    response = self._open(req, data)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 422, in _open
    '_open', req)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 1222, in https_open
    return self.do_open(httplib.HTTPSConnection, req)
  File "c:\buildbot\bbot-master\chromium_brave_win64\build\src\third_party\depot_tools\win_tools-2_7_6_bin\python\bin\lib\urllib2.py", line 1184, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 1] _ssl.c:507: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version>

We are workarounding it for now setting for those build rules npm run init || ( python src/electron/script/update-external-binaries.py && npm run init) but if it might be interesting to force the usage of the system phyton on every case.

@MaoShultz
Copy link

@jonathansampson
Copy link
Collaborator

For anybody wondering, the above workaround didn't work for me in Powershell. Instead, I had to use Git Bash to run the command as-is. I did not test Command Prompt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants