Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in v2.20.1 #14

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Merge in v2.20.1 #14

merged 12 commits into from
Jul 24, 2024

Conversation

joelim41
Copy link

Merges v2.20.1 into our fork

The previous patches applied cleanly - see the diff: https://github.com/braze-inc/mongo-ruby-driver/compare/v2.20.1..merge-2.20.1

jamis and others added 12 commits April 2, 2024 08:09
* Clarify documentation for forking servers

* Tweaks

* More tweaks

* Correct method name
* let's try out codeql

* .evergreen/tools.rb is not referenced anywhere

we can remove it, to remove the warnings it generates

* this is not well-documented; hopefully this works to exclude those paths

* action docs say this should be a "YAML string"

* static analysis reported "Polynomial regular expression used on uncontrolled data"
* okay, very rough draft of a release GA workflow

* fix ref to mongodb-labs/drivers-github-tools

* action is not prefixed with garasign

* struggling to get some visibility here...

* specify release environment

* fixes

* more fixes

* don't need to load the whole driver just to get the version

* make sure we push the new tag to the repo

* `gh release` commands want a tag name

* I *think* the sig gets placed under $RELEASE_ASSETS?

* remove obsolete release-related code, and add explicit `rake release` task

* okay, dummy gem name in gemspec, let's see if the gem gets pushed

* okay, let's try using the provided github action instead

* are the backticks being interpolated by the shell?

* whelp, guess we need to bundle install

* don't require the spec organizers unless it is needed

* don't wait for the gem to be released

mostly because our gem is in a non-standard location (expected to be in
pkg/, but we're generating it directly to the root directory)

* bump the gemspec

* linter appeasement

* add documentation related to release verification
* add more tasks to the release workflow

also, add a cleanup workflow for use while testing

* workflows don't have descriptions

* inputs are specified on the trigger, not the workflow

* skip the SBOM generation until we can figure it out

* use bson-ruby asset group, for testing

this is temporary until silk is able to grab the correct sbom lite from
the mongo-ruby-driver repo

* put code scan results in S3_ASSETS

and for testing, remove dry-run from s3 upload, to make sure it works

* restore the correct silk asset group

* refactor to try the new ruby actions in drivers-github-tools

* remove stray quotation mark

* use the canonical version of the ruby actions

* Indicate `dry_run` to be of type boolean

This is so it gets rendered as a checkbox. We'll default it to `true` to avoid accidental releases.
Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
@joelim41 joelim41 requested review from a team and jonhyman July 10, 2024 17:55
@jasonpenny
Copy link

I see a bunch of tests fail with the upstream test matrix, I think we should run the tests for this version in gemtester before we say its ready

image

@joelim41
Copy link
Author

Passing with gemtester - https://github.com/braze-inc/gemtester/compare/mongo-2.20.1

@joelim41 joelim41 merged commit 1cf4db6 into deployed-in-platform Jul 24, 2024
75 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants