Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I translated that into french :D #25

Closed
Chironeyes opened this issue Apr 9, 2020 · 4 comments
Closed

I translated that into french :D #25

Chironeyes opened this issue Apr 9, 2020 · 4 comments
Labels
feature request New feature or request

Comments

@Chironeyes
Copy link
Contributor

Finally in french !

First, thanks for this fresh addon !

I searched for a french version but i can't find it, probably it doesn't exist ? =p

So I made some modifications to translate it into french.
This is the link to my french version ! (from google drive) :)

Game Version : 1.13.4.33920
ECS Version : 2.2.1

Cheers !

PS: I added my nickname to the readme and the .toc file ^^''

@Chironeyes Chironeyes added the feature request New feature or request label Apr 9, 2020
@BreakBB
Copy link
Owner

BreakBB commented Apr 14, 2020

@GeekToBe1 Thank you very much for this. I already added the first steps for this addon to be translated into multiple languages and it will be easy to add your French translations 👍

@BreakBB
Copy link
Owner

BreakBB commented May 24, 2020

Hey @GeekToBe1 I finally finished the logic to change the language and added a first translation (German).

Could you go through the strings again and match it with the translations you already added to your google document? I have no clue about French and don't really want to "guess" when translating/matching the texts.

@Chironeyes
Copy link
Contributor Author

Chironeyes commented May 24, 2020

I went to see and you did realy good work ! Congratulations :)
However, the addon don't work... /esc commands doesn't work =/

Can you fix that please ?
Wow Classic
ECS from 2.4.0 to 2.4.2

Important questions :
After created fr.lua I uncomment Line 129 in Config.lua "-- ["frFR"] = "Français"," and at line 18 in i18n.lua I change the first "else" into elseif and add one "else i18n:UseFrench()" and that's all ?


EDIT:
Work done boss !
fr.lua

@BreakBB
Copy link
Owner

BreakBB commented May 24, 2020

@GeekToBe1 Wow mate. That was really quick! I hope to include this very soon in an updated and fixed version of ECS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants