Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize analyze #87

Closed
rouille opened this issue Mar 24, 2020 · 2 comments
Closed

Reorganize analyze #87

rouille opened this issue Mar 24, 2020 · 2 comments

Comments

@rouille
Copy link
Collaborator

rouille commented Mar 24, 2020

Reorganize postreise/analyze.. We are leaning towards the following strucutre:

postreise/analyze/transmission contains congestion.py, mwmiles.py, statelines.py, utilization.py (renamed from transmission.py).
postreise/analyze/generation contains carbon.py, curtailment.py, summarize.py

The helpers module would stay in postreise/analyze for the moment since functions defined therein are grid related and hence could be used in both transmission and congestion analyses.

@rouille
Copy link
Collaborator Author

rouille commented Mar 25, 2020

the design_transmission module in powersimdata/input/ imports the haversine function located in the mwmiles module. The latter module has been moved from postreise/analyze/ to postreise/analyze/transmission'. Thus a PR will be created in PowerSimData to fix the import.

@rouille
Copy link
Collaborator Author

rouille commented Mar 25, 2020

The haversine function has been moved into the distance module now located in postreise/analyze/transmission. There two functions in this module now calculating the distance separating two locations. As mentionned by @danielolsen, only one should be used. This will be done in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants